Fix warning about signedness of pointers
Robert Shearman
rob at codeweavers.com
Fri Nov 4 23:07:42 CST 2005
Vincent Béron wrote:
>Changelog:
>Fix warning about signedness of pointers in x11drv.
>
>Vincent
>
>
>------------------------------------------------------------------------
>
>Index: dlls/x11drv/event.c
>===================================================================
>RCS file: /home/wine/wine/dlls/x11drv/event.c,v
>retrieving revision 1.59
>diff -u -r1.59 event.c
>--- dlls/x11drv/event.c 12 Sep 2005 15:14:07 -0000 1.59
>+++ dlls/x11drv/event.c 4 Nov 2005 00:13:43 -0000
>@@ -698,7 +698,7 @@
>
> if( !aux_long && p_data) /* don't bother if > 64K */
> {
>- signed char *p = (signed char*) p_data;
>+ char *p = (char *)p_data;
> char *p_drop;
>
> aux_long = 0;
>@@ -736,7 +736,7 @@
> lpDrop->fWide = FALSE;
> WIN_ReleasePtr(pDropWnd);
> p_drop = (char *)(lpDrop + 1);
>- p = p_data;
>+ p = (char *)p_data;
> while(*p)
> {
> if( *p != -1 ) /* use only "good" entries */
>
>
Mike McCormack already tried an identical patch, but it was rejected
because the implications of the fix were not considered. It doesn't seem
that they were addressed in this patch either. IIRC, the main issue was
that *p can in fact be negative.
--
Rob Shearman
More information about the wine-devel
mailing list