Gabriel Ivăncescu : qedit: Check for S_OK when enumerating the splitter pin.
Alexandre Julliard
julliard at winehq.org
Mon Apr 27 15:19:31 CDT 2020
Module: wine
Branch: master
Commit: 317d5c96886886f7193df06caf80246ec9a3b719
URL: https://source.winehq.org/git/wine.git/?a=commit;h=317d5c96886886f7193df06caf80246ec9a3b719
Author: Gabriel Ivăncescu <gabrielopcode at gmail.com>
Date: Mon Apr 27 16:07:41 2020 +0300
qedit: Check for S_OK when enumerating the splitter pin.
The splitter may return S_FALSE (no pins) and this caused a crash when it
somehow matched with the File Source (Async).
Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/qedit/mediadet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/qedit/mediadet.c b/dlls/qedit/mediadet.c
index eb7a51928b..c3891c5cd3 100644
--- a/dlls/qedit/mediadet.c
+++ b/dlls/qedit/mediadet.c
@@ -197,7 +197,7 @@ static HRESULT find_splitter(MediaDetImpl *detector)
hr = IEnumPins_Next(enum_pins, 1, &splitter_pin, NULL);
IEnumPins_Release(enum_pins);
- if (FAILED(hr))
+ if (hr != S_OK)
goto next;
hr = IPin_Connect(source_pin, splitter_pin, NULL);
More information about the wine-cvs
mailing list