Michael Stefaniuc : d3dx9: Merge the d3dx_effect_GetString() helper.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: ea45ed1751860905daa33af5e45d38cbbeadd0ad
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=ea45ed1751860905daa33af5e45d38cbbeadd0ad

Author: Michael Stefaniuc <mstefani at winehq.org>
Date:   Wed Mar 13 00:10:54 2019 +0100

d3dx9: Merge the d3dx_effect_GetString() helper.

Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/d3dx9_36/effect.c | 29 +++++++++++------------------
 1 file changed, 11 insertions(+), 18 deletions(-)

diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
index 554d43d..a81e330 100644
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -1515,23 +1515,6 @@ static HRESULT d3dx9_base_effect_set_string(struct d3dx9_base_effect *base,
     return D3DERR_INVALIDCALL;
 }
 
-static HRESULT d3dx9_base_effect_get_string(struct d3dx9_base_effect *base,
-        D3DXHANDLE parameter, const char **string)
-{
-    struct d3dx_parameter *param = get_valid_parameter(base, parameter);
-
-    if (string && param && !param->element_count && param->type == D3DXPT_STRING)
-    {
-        *string = *(const char **)param->data;
-        TRACE("Returning %s.\n", debugstr_a(*string));
-        return D3D_OK;
-    }
-
-    WARN("Parameter not found.\n");
-
-    return D3DERR_INVALIDCALL;
-}
-
 static HRESULT d3dx9_base_effect_set_texture(struct d3dx9_base_effect *base,
         D3DXHANDLE parameter, struct IDirect3DBaseTexture9 *texture)
 {
@@ -3561,10 +3544,20 @@ static HRESULT WINAPI d3dx_effect_SetString(ID3DXEffect *iface, D3DXHANDLE param
 static HRESULT WINAPI d3dx_effect_GetString(ID3DXEffect *iface, D3DXHANDLE parameter, const char **string)
 {
     struct d3dx_effect *effect = impl_from_ID3DXEffect(iface);
+    struct d3dx_parameter *param = get_valid_parameter(&effect->base_effect, parameter);
 
     TRACE("iface %p, parameter %p, string %p.\n", iface, parameter, string);
 
-    return d3dx9_base_effect_get_string(&effect->base_effect, parameter, string);
+    if (string && param && !param->element_count && param->type == D3DXPT_STRING)
+    {
+        *string = *(const char **)param->data;
+        TRACE("Returning %s.\n", debugstr_a(*string));
+        return D3D_OK;
+    }
+
+    WARN("Parameter not found.\n");
+
+    return D3DERR_INVALIDCALL;
 }
 
 static HRESULT WINAPI d3dx_effect_SetTexture(struct ID3DXEffect *iface, D3DXHANDLE parameter,