Alexandre Julliard : server: Avoid potential double free (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Oct 16 14:38:31 CDT 2017


Module: wine
Branch: master
Commit: af238f5653a4dd1656eb2027d1605e8088613772
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=af238f5653a4dd1656eb2027d1605e8088613772

Author: Alexandre Julliard <julliard at winehq.org>
Date:   Mon Oct 16 15:28:38 2017 +0200

server: Avoid potential double free (Coverity).

Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 server/mapping.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/mapping.c b/server/mapping.c
index f9f50ed..d9bff4b 100644
--- a/server/mapping.c
+++ b/server/mapping.c
@@ -507,13 +507,13 @@ static int build_shared_mapping( struct mapping *mapping, int fd,
         }
         if (pwrite( shared_fd, buffer, file_size, write_pos ) != file_size) goto error;
     }
-    free( buffer );
 
     if (!(shared = alloc_object( &shared_map_ops ))) goto error;
     shared->fd = (struct fd *)grab_object( mapping->fd );
     shared->file = file;
     list_add_head( &shared_map_list, &shared->entry );
     mapping->shared = shared;
+    free( buffer );
     return 1;
 
  error:




More information about the wine-cvs mailing list