Nikolay Sivov : shell32: Free cloned PIDL after tree initialization ( Valgrind).
Alexandre Julliard
julliard at winehq.org
Thu Jan 20 12:41:21 CST 2011
Module: wine
Branch: master
Commit: 2d542fa752506c551fbd1c792016fa8f1dc6f9c3
URL: http://source.winehq.org/git/wine.git/?a=commit;h=2d542fa752506c551fbd1c792016fa8f1dc6f9c3
Author: Nikolay Sivov <nsivov at codeweavers.com>
Date: Thu Jan 20 01:41:18 2011 +0300
shell32: Free cloned PIDL after tree initialization (Valgrind).
---
dlls/shell32/brsfolder.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/dlls/shell32/brsfolder.c b/dlls/shell32/brsfolder.c
index e990c61..705bdfa 100644
--- a/dlls/shell32/brsfolder.c
+++ b/dlls/shell32/brsfolder.c
@@ -228,6 +228,7 @@ static void InitializeTreeView( browse_info *info )
hr = SHGetDesktopFolder(&lpsfDesktop);
if (FAILED(hr)) {
WARN("SHGetDesktopFolder failed! hr = %08x\n", hr);
+ ILFree(pidlChild);
return;
}
hr = IShellFolder_BindToObject(lpsfDesktop, pidlParent, 0, &IID_IShellFolder, (LPVOID*)&lpsfParent);
@@ -236,6 +237,7 @@ static void InitializeTreeView( browse_info *info )
if (FAILED(hr)) {
WARN("Could not bind to parent shell folder! hr = %08x\n", hr);
+ ILFree(pidlChild);
return;
}
@@ -249,6 +251,7 @@ static void InitializeTreeView( browse_info *info )
if (FAILED(hr)) {
WARN("Could not bind to root shell folder! hr = %08x\n", hr);
IShellFolder_Release(lpsfParent);
+ ILFree(pidlChild);
return;
}
@@ -258,6 +261,7 @@ static void InitializeTreeView( browse_info *info )
WARN("Could not get child iterator! hr = %08x\n", hr);
IShellFolder_Release(lpsfParent);
IShellFolder_Release(lpsfRoot);
+ ILFree(pidlChild);
return;
}
@@ -266,6 +270,7 @@ static void InitializeTreeView( browse_info *info )
pidlParent, pEnumChildren, TVI_ROOT );
SendMessageW( info->hwndTreeView, TVM_EXPAND, TVE_EXPAND, (LPARAM)item );
+ ILFree(pidlChild);
IShellFolder_Release(lpsfRoot);
IShellFolder_Release(lpsfParent);
}
More information about the wine-cvs
mailing list